test: add common.fixtures to https-req-split#15801
Closed
BruceFletcher wants to merge 3 commits intonodejs:masterfrom
Closed
test: add common.fixtures to https-req-split#15801BruceFletcher wants to merge 3 commits intonodejs:masterfrom
BruceFletcher wants to merge 3 commits intonodejs:masterfrom
Conversation
richardlau
reviewed
Oct 6, 2017
| key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`), | ||
| cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`) | ||
| key: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-key.pem`), | ||
| cert: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-cert.pem`) |
Member
There was a problem hiding this comment.
The fs.readFileSync calls could be replaced with fixtures.readKey.
Author
There was a problem hiding this comment.
Thanks, test updated. Do I need to do anything else to update the PR?
richardlau
approved these changes
Oct 6, 2017
watilde
approved these changes
Oct 6, 2017
Member
Trott
added
the
code-and-learn
gireeshpunathil
approved these changes
Oct 7, 2017
cjihrig
approved these changes
Oct 7, 2017
benjamingr
approved these changes
Oct 7, 2017
Member
Trott
approved these changes
Oct 7, 2017
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM. If there are no issues with the CI run, I think this can land without waiting the full 72 hours.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 7, 2017
Replaced readFileSync with fixtures.readKey. PR-URL: nodejs#15801 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in baa156f. Thanks for the contribution! 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 7, 2017
Replaced readFileSync with fixtures.readKey. PR-URL: #15801 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
Replaced readFileSync with fixtures.readKey. PR-URL: #15801 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Replaced readFileSync with fixtures.readKey. PR-URL: nodejs/node#15801 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)